fix: FILTER_SANITIZE_STRING deprecation #186
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced with htmlspecialchars
|
Looks like |
|
Good catch @otacke I'll amend my PR |
|
@arzola That comment was not necessarily directed towards you. But if you have time to replace the other occurrences, too, even better. Hopefully H5P Group is going to merge your request in soon. |
|
@otacke I created a trait that could be used to centralize some utility functions like this sanitization process. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
PHP Deprecated: Constant FILTER_SANITIZE_STRING is deprecated
Solution
Replace current deprecated code with a suitable option, keeping current functionality intact
Address #152 #170
Input Sanitization Improvements:
H5PUtilstrait that includes asanitize_inputmethod to replace the deprecatedFILTER_SANITIZE_STRINGfilter. (admin/class-h5p-utils.php)H5PContentAdminto use the newsanitize_inputmethod for sanitizing input variables. (admin/class-h5p-content-admin.php) [1] [2] [3] [4] [5] [6] [7]H5PLibraryAdminto use the newsanitize_inputmethod for sanitizing input variables. (admin/class-h5p-library-admin.php) [1] [2]alter_titlemethod inH5PPluginAdminto usehtmlspecialcharsfor sanitizing thepageinput variable. (admin/class-h5p-plugin-admin.php)Code Organization:
H5PUtilstrait to the autoloader to ensure it is properly loaded. (autoloader.php)H5PUtilstrait in theH5PContentAdminandH5PLibraryAdminclasses to utilize the new sanitization method. (admin/class-h5p-content-admin.php,admin/class-h5p-library-admin.php) [1] [2]