Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add New_PCB board #1022

Merged
merged 9 commits into from
Aug 26, 2024
Merged

Add New_PCB board #1022

merged 9 commits into from
Aug 26, 2024

Conversation

RohitPandey1729
Copy link
Contributor

Submission Checklist:

  • [X ] I am a current high school, middle school, or home schooled student.

  • [ X] I have joined the #electronics channel on Slack

  • [ X] I made this board from scratch, even if I followed a tutorial

  • [ X] I have followed the directions in README.md

    • [ X] Created a folder under onboard/projects
    • [ X] Filled out TEMPLATE.md as README.md inside your project folder
    • [ X] Uploaded gerber.zip and schematic.pdf inside your project folder
    • [ X] Created a folder called src and uploaded design files
    • [ X] Uploaded screenshot of PCB order called cart.png with all costs included
    • [ X] I am ordering the smallest batch size (ie. JLCPCB's smallest order is for 5 boards)
    • [ X] If outside the US I've checked that I can afford the customs charges in my country (which isn't covered by the grant)
  • (Optional) This project is from a tutorial1.

  • (Optional) This project is for OnBoard Live2.

  • (Optional) I'm in a FIRST (FRC, FTC, FLL, etc.) team. The number is: ____

Footnotes

  1. Projects from a tutorial are 100% fine! We just want to ask so we can count how people are using tutorials.

  2. OnBoard Live is a special version of OnBoard where you can earn more money for designing advanced boards. Check out the #onboard-live channel on our Slack!

@github-actions github-actions bot added the Submission New Boards! label Aug 23, 2024
@prophetorpheus
Copy link
Collaborator

prophetorpheus commented Aug 23, 2024

Hi, I'm Orpheus Leap! Here to help you review your PR.

projects/New_PCB:

Required files

README.md A description of your project
cart.png cart.png
gerber.zip
schematic.pdf You must export your schematic file as schematic.pdf
Source files - EasyEDA Found both PCB and SCH files

You can view a render of your board over on gerber.zip/2d!

Happy OnBoarding!
This bot is a simpler helper for common submission types. If there's an error with this, please point it out and someone from the OnBoard team will look at it manually.

@blazecoding2009 blazecoding2009 self-assigned this Aug 24, 2024
Copy link
Collaborator

@blazecoding2009 blazecoding2009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @RohitPandey1729

Thanks for submitting your PCB pull request for OnBoard! However, it looks like you took a picture of the cart ordering process instead of completing the checkout process. For us to have the full picture of pricing and the PCB your ordering, please follow the steps in this guide here or here:

  1. Click "Secure Checkout": After adding your PCB to the cart
  2. Enter your shipping information and add a coupon code if you have one, then click "Submit Order", do not add any payment options
  3. Close that tab and open a new one to jlcpcb.com, then click "Order History" and take a screenshot. It should show all the details of your order.

Please take a screenshot of your unpaid order instead of a picture of your cart, and upload it as cart.png. This will allow us to spot any mistakes and give you ways to reduce the cost or customs fee. Congrats on making the PCB!

@RohitPandey1729
Copy link
Contributor Author

So, after that do I make a new pr? Or use the same one

@blazecoding2009
Copy link
Collaborator

So, after that do I make a new pr? Or use the same one

do not create a new PR, the commits show up here

@RohitPandey1729
Copy link
Contributor Author

RohitPandey1729 commented Aug 26, 2024

I sent the cart.png

Copy link
Collaborator

@blazecoding2009 blazecoding2009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename them files correctly.
image

@RohitPandey1729
Copy link
Contributor Author

I fixed the names but I do not know how to delete the second cart.png.png

Copy link
Collaborator

@blazecoding2009 blazecoding2009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I've sent your grant

@RohitPandey1729
Copy link
Contributor Author

Thank you!

@blazecoding2009 blazecoding2009 merged commit 7de7eca into hackclub:main Aug 26, 2024
3 checks passed
24c02 pushed a commit that referenced this pull request Oct 8, 2024
* Add the New_PCB readme

* Add New-PCB files

* added the cart.png

* Rename gerber.zip.zip to gerber.zip

* Rename Schematic.pdf.pdf to Schematic.pdf

* Update README.md

---------

Co-authored-by: blaze <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Submission New Boards!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants