-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add New_PCB board #1022
Add New_PCB board #1022
Conversation
Hi, I'm Orpheus Leap! Here to help you review your PR.
projects/New_PCB: Required files
You can view a render of your board over on gerber.zip/2d! Happy OnBoarding! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @RohitPandey1729
Thanks for submitting your PCB pull request for OnBoard! However, it looks like you took a picture of the cart ordering process instead of completing the checkout process. For us to have the full picture of pricing and the PCB your ordering, please follow the steps in this guide here or here:
- Click "Secure Checkout": After adding your PCB to the cart
- Enter your shipping information and add a coupon code if you have one, then click "Submit Order", do not add any payment options
- Close that tab and open a new one to jlcpcb.com, then click "Order History" and take a screenshot. It should show all the details of your order.
Please take a screenshot of your unpaid order instead of a picture of your cart, and upload it as cart.png. This will allow us to spot any mistakes and give you ways to reduce the cost or customs fee. Congrats on making the PCB!
So, after that do I make a new pr? Or use the same one |
do not create a new PR, the commits show up here |
I sent the cart.png |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed the names but I do not know how to delete the second cart.png.png |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I've sent your grant
Thank you! |
* Add the New_PCB readme * Add New-PCB files * added the cart.png * Rename gerber.zip.zip to gerber.zip * Rename Schematic.pdf.pdf to Schematic.pdf * Update README.md --------- Co-authored-by: blaze <[email protected]>
Submission Checklist:
[X ] I am a current high school, middle school, or home schooled student.
[ X] I have joined the
#electronics
channel on Slack[ X] I made this board from scratch, even if I followed a tutorial
[ X] I have followed the directions in README.md
onboard/projects
TEMPLATE.md
asREADME.md
inside your project foldergerber.zip
andschematic.pdf
inside your project foldersrc
and uploaded design filescart.png
with all costs included(Optional) This project is from a tutorial1.
(Optional) This project is for OnBoard Live2.
(Optional) I'm in a FIRST (FRC, FTC, FLL, etc.) team. The number is: ____
Footnotes
Projects from a tutorial are 100% fine! We just want to ask so we can count how people are using tutorials. ↩
OnBoard Live is a special version of OnBoard where you can earn more money for designing advanced boards. Check out the #onboard-live channel on our Slack! ↩