Customized and extended tailwind styles #439
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #429
Changes
Problem--needs discussion:
Currently, we imported
import "tailwindcss/tailwind.css"; import "./index.scss";
in such order so that tailwind styles don't override existing components styled with Sass. However, some Sass classes share the same names (e.g. p for padding) but have different values. For example, p-1 in our Sass ispadding: 8px;
but in tailwind p-1 ispadding: 0.25rem; /* 4px */
and because of this, new components relying on TW classes can't use p1-p6 to get TW styles. I think we would either need to do some conversion or override Sass styles in another way, but maybe there's a better way of handling these conflicts?