-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use uv to manage dependencies #268
Conversation
a5ef8b9
to
cb897c7
Compare
Rebased to latest main and force pushed |
Found a problem when running where |
cb897c7
to
dd809ad
Compare
restored the missing apt dependencies and force pushed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fyliu these are my observations while testing
-
./scripts/update-dependencies.sh
can't be found in the branch -
./scripts/buildrun.sh
works great, as desireduv
gets downloaded and we are using the djaongo version of4.2.11
-
./scripts.test.sh
also works good as well -
./scripts/erd.sh
I'm not sure what it does except, it should show and ERD diagram, but all I got as an output is>> ./scripts/erd.sh + docker-compose exec web python manage.py graph_models --pydot -a -g -o erd.png
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fyliu Thanks for working on the changes, the script update-dependencies.sh
is available and on execution make changes to requirement.txt
by updating the versions.
I'm still not sure on the ./scripts/erd.sh
, can't find an end.png
@freaky4wrld It should be in ❯ file app/erd.png
app/erd.png: PNG image data, 5113 x 1379, 8-bit/color RGBA, non-interlaced I also amended the erd commit with the location of the generated image. |
01f961f
to
434cdd3
Compare
434cdd3
to
bc309b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fyliu thanks for making the changes, here is my observations as per the new changes done:
update-dependencies.sh
produces updated version of tools inrequirements.txt
build run.sh
runs successfullyerd.sh
produceserd.png
in the app directorytest.sh
successfully checks for the test provided
PR approved!!!! Thanks for your contribution, really appreciate all your efforts :)
Fixes #178
Fixes #183
What changes did you make?
Why did you make the changes (we will use this info to test)?
How to test
./scripts/update-dependencies.sh
./scripts/buildrun.sh
./scripts/erd.sh
./scripts/test.sh