Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify contributing #395

Merged
merged 19 commits into from
Oct 17, 2024
Merged

Simplify contributing #395

merged 19 commits into from
Oct 17, 2024

Conversation

fyliu
Copy link
Member

@fyliu fyliu commented Oct 2, 2024

Fixes #267

What changes did you make?

  • Moved CONTRIBUTING.md sections into files and created links from the original file
    • The original file became the section index page.
  • Created contributing/ directory and moved contributing files inside
  • Moved tools/ and howto/ (Developer How-to Guides) into contributing/
  • Updated links for the above changes.

Why did you make the changes (we will use this info to test)?

  • To split the long contributing docs file into topic pages so it'll be easier to add and make changes going forward.
  • To organize contributing pages into the Contributing section. Leave main sections for user/customer documentation.

Screenshots of Proposed Changes Of The Website

Before link

Visuals before changes are applied
  • Boxes show where the pages were originally.
  • The page table of contents used to be on the right.
  • There were numbering in the titles, because the document was so long
    • Having numbers as part of the titles (rounded boxes) made it difficult to insert new content because of having to re-number everything after it.

2024-10-03 09 37 34 hackforla github io e4315503883e

After link

Visuals after changes are applied
  • Now, all contributor pages are organized under the "Contributing" section (boxed), leaving the main sections for "customers" (API client developers).
  • There's a Contributing index page with links pointing to the other pages.

2024-10-02 14 50 42 localhost 38543a596a76

  • Now, page table of contents is shorter and reads better without numbering all the titles

2024-10-10 15 30 50 fyliu github io a1818e68d0a4

- compose file no longer uses versioning
- Dockerfile env vars use = signs
@fyliu fyliu self-assigned this Oct 3, 2024
@fyliu fyliu marked this pull request as ready for review October 3, 2024 17:26
@shmonks shmonks self-requested a review October 4, 2024 00:23
@fyliu fyliu marked this pull request as draft October 7, 2024 16:46
@fyliu
Copy link
Member Author

fyliu commented Oct 7, 2024

Maybe the 2 vs. 3 column display needs some more thinking through. I'm going to remove that and recreate screenshots for this PR.

The reasoning is that the Stripe docs use the 3-column format, and it's been the gold standard for software API documentation for a long time. Maybe it's something that users (client developers) prefer.

@fyliu fyliu marked this pull request as ready for review October 10, 2024 22:35
These are the developer guides for how to do specific things with the project.

1. [Add model and API endpoints](add-model-and-api-endpoints.md)
1. [Create initial data migrations](create-initial-data-migrations.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 6: Change to 'Create initial data scripts' - and maybe change the name of the linked .md file too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should change the wording here.

Migrations is the term Django uses for this type of scripts. They don't work alone, but have to be run by Django's migration system. https://docs.djangoproject.com/en/5.1/topics/migrations/

It took a while to compare and figure out the best format to keep the initial data and insert them into the database. I should write up a DR to document why.


1. Browse to the web admin interface at `http://localhost:8000/admin/` and confirm the admin site is running. Use DJANGO_SUPERUSER_USERNAME and DJANGO_SUPERUSER_PASSWORD from .env.docker for credentials.

See our documentation for [Working with Docker](http://localhost:8005/contributing/tools/docker/#working-with-docker) for more useful Docker commands.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 165: is the link to Working with Docker page to be inserted later?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! localhost is definitely a placeholder link that didn't get cleaned up.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

docs/contributing/index.md Outdated Show resolved Hide resolved
docs/contributing/index.md Outdated Show resolved Hide resolved
Copy link
Member

@shmonks shmonks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good! A few tiny corrections and a couple of comments, that's all.

@fyliu fyliu merged commit 5e3439f into hackforla:main Oct 17, 2024
1 check passed
@fyliu fyliu deleted the simplify-contributing branch December 3, 2024 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅Done
Development

Successfully merging this pull request may close these issues.

docs: simplify contributing page
2 participants