Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

smilehax-IIe jpn instructions #2365

Merged
merged 3 commits into from
Oct 4, 2023
Merged

smilehax-IIe jpn instructions #2365

merged 3 commits into from
Oct 4, 2023

Conversation

mirrormirrorontheweb
Copy link
Contributor

@mirrormirrorontheweb mirrormirrorontheweb commented Sep 8, 2023 •
edited
Loading

same as #2364
main is @SirGamers

@mirrormirrorontheweb mirrormirrorontheweb changed the title smilehax-IIe jpn jpn instructions smilehax-IIe jpn instructions Sep 8, 2023
@lifehackerhansol
Copy link
Contributor

Want to ask for comments for others here: since this is JPN specific, would we want to write all the game text in JPN lol

Remainder seems fairly solid to me I think

Gruetzig
Gruetzig suggested changes Oct 1, 2023
View reviewed changes
Copy link
Contributor

@Gruetzig Gruetzig left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

>.> In addition, you probably want to add the newly created page to sitenav, and the javascript in order for the page to work correctly in the progress thingie.

_pages/en_US/installing-boot9strap-(smilehax-iie).txt Outdated Show resolved Hide resolved
_pages/en_US/installing-boot9strap-(smilehax-iie-jpn).txt Outdated Show resolved Hide resolved
_pages/en_US/installing-boot9strap-(smilehax-iie-jpn).txt Outdated Show resolved Hide resolved
_pages/en_US/installing-boot9strap-(smilehax-iie-jpn).txt Outdated Show resolved Hide resolved
_pages/en_US/installing-boot9strap-(smilehax-iie-jpn).txt Outdated Show resolved Hide resolved
_pages/en_US/installing-boot9strap-(smilehax-iie-jpn).txt Outdated Show resolved Hide resolved
Gruetzig
Gruetzig suggested changes Oct 3, 2023
View reviewed changes
_pages/en_US/installing-boot9strap-(smilehax-iie).txt Outdated Show resolved Hide resolved
_pages/en_US/alternate-exploits.txt Outdated Show resolved Hide resolved
@Gruetzig
Copy link
Contributor

Gruetzig commented Oct 3, 2023 •
edited
Loading

./ITI\.

@lifehackerhansol lifehackerhansol force-pushed the smilehax-IIe-jpn branch 4 times, most recently from 512c8b0 to d5c27e5 Compare October 3, 2023 17:00
lilyuwuu
lilyuwuu approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@lilyuwuu lilyuwuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly lgtm

_pages/en_US/installing-boot9strap-(smilehax-iie-jpn).txt Outdated Show resolved Hide resolved
_pages/en_US/installing-boot9strap-(smilehax-iie-jpn).txt Show resolved Hide resolved
_pages/en_US/alternate-exploits.txt Outdated Show resolved Hide resolved
_pages/en_US/installing-boot9strap-(smilehax-iie-jpn).txt Outdated Show resolved Hide resolved
_pages/en_US/installing-boot9strap-(smilehax-iie-jpn).txt Outdated Show resolved Hide resolved
_pages/en_US/installing-boot9strap-(smilehax-iie-jpn).txt Outdated Show resolved Hide resolved
_pages/en_US/installing-boot9strap-(smilehax-iie-jpn).txt Show resolved Hide resolved
@lifehackerhansol lifehackerhansol merged commit cbc2f4e into hacks-guide:master Oct 4, 2023
1 check passed
@Gruetzig
Copy link
Contributor

Gruetzig commented Oct 4, 2023

DAS DSA SAD SDA ADS ASD

@mirrormirrorontheweb mirrormirrorontheweb deleted the smilehax-IIe-jpn branch October 4, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gruetzig Gruetzig Gruetzig approved these changes

@lifehackerhansol lifehackerhansol lifehackerhansol approved these changes

@lilyuwuu lilyuwuu Awaiting requested review from lilyuwuu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mirrormirrorontheweb @lifehackerhansol @Gruetzig @lilyuwuu @SirGamers