Add EBNF for AST to book #1066
Add EBNF for AST to book #1066
Conversation
|
We chatted about this, we said we should put that file in the book directly in a "Input language" section that contains the grammar for the input language (filtering features already for |
|
@cmester0 shall this be still a draft PR? |
|
Let's chat, it feels like some rules are missing, e.g. generic params |
book/src/contributing/ast_ebnf.md
Outdated
| | "self" | ||
| | goal | ||
| | "dyn" | ||
| | <!TODO!> |
There was a problem hiding this comment.
I guess we can remove this TODO altogether?
The category impl is a bit weird since it has no Rust syntax, but I think it's fine
book/src/contributing/ast_ebnf.md
Outdated
| | (ty "->")* ty | ||
| | impl "::" ident | ||
| | "impl" ty | ||
| | (goal)* |
There was a problem hiding this comment.
I don't get this (goal)* line here. From what variant in AST does this come from?
There was a problem hiding this comment.
Should be
| "dyn" (goal)*
| | "use" path ";" | ||
| ``` | ||
|
|
||
| The full AST description |
There was a problem hiding this comment.
The full AST description is really just a cat of all previous ebnf code blocks, right?
I guess this is for visualization?
In that case, let's just create a EBNF file on the side or something like that.
There was a problem hiding this comment.
Yes, wanted it to have the full description somewhere, but could just be a separate file.
There was a problem hiding this comment.
Throwing this onto https://rr.red-dove.com/ui gives me errors. Can you check what's wrong?
There was a problem hiding this comment.
Seems it does not like escaping " as \". And comments/TODO formatting is incorrect.
book/src/SUMMARY.md
Outdated
| @@ -15,6 +15,7 @@ | |||
| - [F*]() | |||
| - [Coq]() | |||
| - [`libcore`]() | |||
| - [AST](contributing/ast_ebnf.md) | |||
There was a problem hiding this comment.
Shouldn't this be moved in the section contributing? Or be named something like "Input language"?
For now, I'd say we should move it to Contributing
|
Shall I review again @cmester0? is this in a good shape? Also there is a conflict |
No description provided.