Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(engine): keep track of parent items in spans #1080

Merged
merged 5 commits into from
Nov 13, 2024

Conversation

W95Psp
Copy link
Collaborator

@W95Psp W95Psp commented Oct 31, 2024

This PR:

  • makes spans carry a hint about their parent item;
  • makes errors carry a hint about which item the error comes from;
  • adds a --stats flag to the verb into, printing information about how many items the engine was able to process and a total number of items.

This will be quite useful for mass testing the engine: we'll be able to have statistics about how many items in a crate we can translate.

@W95Psp W95Psp requested a review from maximebuyse October 31, 2024 08:22
@W95Psp W95Psp force-pushed the record-item-idents-in-diagnostics branch from 608f391 to 82e082e Compare October 31, 2024 08:53
@maximebuyse maximebuyse enabled auto-merge October 31, 2024 09:01
@W95Psp
Copy link
Collaborator Author

W95Psp commented Oct 31, 2024

Note to myself: is that a regression because of span comparison/equality somewhere in the code?
Trying to define by hand the equality and comparison for spans ommitting the owner id might fix this
But we should not rely on span comparison...

We may want to use the "real" equality inside the module span, and then expose an always true equality/comparison for consumer of that module.

@W95Psp W95Psp force-pushed the record-item-idents-in-diagnostics branch from 82e082e to 9c0cba0 Compare November 12, 2024 17:01
@maximebuyse maximebuyse added this pull request to the merge queue Nov 13, 2024
Merged via the queue into main with commit a8acd9b Nov 13, 2024
14 checks passed
@maximebuyse maximebuyse deleted the record-item-idents-in-diagnostics branch November 13, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants