Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ml-kem ci job. #1094

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Fix ml-kem ci job. #1094

merged 1 commit into from
Nov 4, 2024

Conversation

maximebuyse
Copy link
Contributor

@maximebuyse maximebuyse commented Nov 4, 2024 •
edited
Loading

Fixes #1086

@maximebuyse
Copy link
Contributor Author

I tried the new job with https://github.com/hacspec/hax/actions/runs/11665242466/job/32477483999 and it does what we want.

The configuration is partly copied from https://github.com/cryspen/libcrux/blob/main/.github/workflows/hax.yml
It would be nice to be able to share some workflow parts with the libcrux repo but that would require a bit of refactoring.

franziskuskiefer
franziskuskiefer approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Let's get this in. We can update this with the workbench, or put a shared action into cryspen/actions later.

@franziskuskiefer franziskuskiefer added this pull request to the merge queue Nov 4, 2024
Merged via the queue into main with commit 4de7454 Nov 4, 2024
15 checks passed
@franziskuskiefer franziskuskiefer deleted the fix-ml-kem-ci branch November 4, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franziskuskiefer franziskuskiefer franziskuskiefer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove/fix libcrux ml-kem CI job
2 participants
@maximebuyse @franziskuskiefer