Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(engine) Drop return/break/continue inside closures. #1101

Merged
merged 1 commit into from
Nov 6, 2024
Merged

fix(engine) Drop return/break/continue inside closures. #1101

merged 1 commit into from
Nov 6, 2024

Conversation

maximebuyse
Copy link
Contributor

@maximebuyse maximebuyse commented Nov 5, 2024 •
edited
Loading

Fixes #1089.

Closures were not treated in the elimination of return/break/continue.

@maximebuyse maximebuyse requested a review from cmester0 November 5, 2024 15:04
@franziskuskiefer
Copy link
Member

As discussed, this appears to need more tests.
Do you want to add more tests separately or in here?

@maximebuyse
Copy link
Contributor Author

As discussed, this appears to need more tests. Do you want to add more tests separately or in here?

I think it makes more sense to do it separately (there is already a new test in here that covers the corresponding bug).

franziskuskiefer
franziskuskiefer approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, then let's get this in and please file a follow up to increase test coverage for break/continue/return?.

@maximebuyse maximebuyse added this pull request to the merge queue Nov 6, 2024
Merged via the queue into main with commit 4291b19 Nov 6, 2024
14 checks passed
@maximebuyse maximebuyse deleted the fix-return-closure branch November 6, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franziskuskiefer franziskuskiefer franziskuskiefer approved these changes

@cmester0 cmester0 Awaiting requested review from cmester0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Question mark in a closure gives an error
2 participants
@maximebuyse @franziskuskiefer