Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Engine: source maps: fix bugs, add features, enable for Coq #1123

Merged
merged 7 commits into from
Nov 22, 2024

Conversation

W95Psp
Copy link
Collaborator

@W95Psp W95Psp commented Nov 21, 2024

This PR:

  • makes cargo hax save source maps as files if the engine produce any
  • fix a bug in the source map encoding
  • output source maps for the Coq backend

To test the source maps for Coq:

@W95Psp W95Psp requested a review from cmester0 November 21, 2024 05:58
@W95Psp W95Psp marked this pull request as draft November 21, 2024 06:08
Copy link
Contributor

@cmester0 cmester0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@W95Psp W95Psp marked this pull request as ready for review November 22, 2024 11:15
@W95Psp W95Psp added this pull request to the merge queue Nov 22, 2024
Merged via the queue into main with commit e4c6c2b Nov 22, 2024
15 checks passed
@W95Psp W95Psp deleted the coq-sourcemaps branch November 22, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants