Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Book: small cleanup #1148

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Book: small cleanup #1148

merged 2 commits into from
Dec 3, 2024

Conversation

W95Psp
Copy link
Collaborator

@W95Psp W95Psp commented Nov 27, 2024 •
edited
Loading

This PR cleans up the book a little, essentially removing greyed-out sections.

As we discussed @karthikbhargavan, see https://github.com/cryspen/home/issues/112.

Note: we need #1120 to get in first.

@W95Psp W95Psp force-pushed the doc-architecture-hax branch 2 times, most recently from 2586158 to afff4b3 Compare November 28, 2024 07:16
Base automatically changed from doc-architecture-hax to main December 3, 2024 10:49
karthikbhargavan
karthikbhargavan approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@karthikbhargavan karthikbhargavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text could likely use some polish, but let's do that as part of the paper writing and copy the final text over here.

@W95Psp W95Psp enabled auto-merge December 3, 2024 12:43
@W95Psp W95Psp added this pull request to the merge queue Dec 3, 2024
Merged via the queue into main with commit de59826 Dec 3, 2024
15 checks passed
@W95Psp W95Psp deleted the book-cleanups branch December 3, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karthikbhargavan karthikbhargavan karthikbhargavan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@W95Psp @karthikbhargavan