Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up of F* libraries #1166

Merged
merged 21 commits into from
Dec 10, 2024
Merged

Clean up of F* libraries #1166

merged 21 commits into from
Dec 10, 2024

Conversation

karthikbhargavan
Copy link
Contributor

This PR adds some missing functions and removes all assumes and admits from the F* library.

@karthikbhargavan
Copy link
Contributor Author

We need to test this on all our projects before merging.

W95Psp
W95Psp approved these changes Dec 5, 2024
View reviewed changes
Copy link
Collaborator

@W95Psp W95Psp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me, but we still need to make sure that's fine with ML-KEM.

@franziskuskiefer franziskuskiefer linked an issue Dec 5, 2024 that may be closed by this pull request
i8::MIN / -1 panics but verifies #1155
Closed
@karthikbhargavan karthikbhargavan added this pull request to the merge queue Dec 10, 2024
Merged via the queue into main with commit 18ac15e Dec 10, 2024
15 checks passed
@karthikbhargavan karthikbhargavan deleted the karthik/fstar-lib branch December 10, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@W95Psp W95Psp W95Psp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

i8::MIN / -1 panics but verifies
2 participants
@karthikbhargavan @W95Psp