Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove rejected type ascription patterns from generated f*. #1174

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Conversation

maximebuyse
Copy link
Contributor

Fixes #1170

This mostly ignores type ascription patterns in the F* backend (maybe we should completely ignore them, see #1170 (comment)). These patterns are translated as their subpattern. This fixes the issue from #1170

The main difference as a side effect is that for

let _: i8 = 1 + 1;

We will now generate

let _:i8 = 1y +! 1y in

instead of

let (_: i8):i8 = 1y +! 1y in

Both are valid F* and the new version is simpler, and clearer.

@maximebuyse maximebuyse requested a review from W95Psp December 9, 2024 10:09
Copy link
Collaborator

@W95Psp W95Psp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that looks good to me!

@W95Psp W95Psp added this pull request to the merge queue Dec 9, 2024
Merged via the queue into main with commit 814a6a2 Dec 9, 2024
15 checks passed
@W95Psp W95Psp deleted the fix-1170 branch December 9, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong type ascription pattern in generated F*
2 participants