fix(F*): always use Type0, never Type
#666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `Type` cause issues, especially in interfaces. An interface with a function with an implicit type parameter typed `Type` means that its universe could be anything, which will never occur in code generated from Rust.
W95Psp
force-pushed
the
type0-instead-of-type
branch
from
cccca64 to
a4552b2
Compare
karthikbhargavan
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
Typecauses issues, especially in interfaces. An interface with a function with an implicit type parameter typedTypemeans that its universe could be anything, which will never occur in code generated from Rust.See also cryspen/libcrux#277
There is a dependency cycle in term of CI, thus I remove the workflow that extract Kyber from the mandatory jobs for now, will