Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(engine): Concrete_ident_generated: name -> t, derive more #727

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

W95Psp
Copy link
Collaborator

@W95Psp W95Psp commented Jun 20, 2024

No description provided.

@W95Psp W95Psp requested a review from jschneider-bensch June 20, 2024 09:47
@W95Psp W95Psp force-pushed the refactor-concrete-ident-generated branch 2 times, most recently from 69be94a to 2d680cb Compare June 20, 2024 09:57
@franziskuskiefer franziskuskiefer added the waiting-on-reviewer Status: Awaiting review from the assignee but also interested parties. label Jun 21, 2024
@W95Psp W95Psp force-pushed the refactor-concrete-ident-generated branch from 2d680cb to e49233f Compare June 24, 2024 08:36
Copy link
Collaborator

@jschneider-bensch jschneider-bensch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good to me! This is very useful, e.g. in #728.

@W95Psp W95Psp force-pushed the refactor-concrete-ident-generated branch from e49233f to cc4d0cb Compare July 1, 2024 09:16
@W95Psp W95Psp enabled auto-merge July 1, 2024 09:16
@W95Psp W95Psp added this pull request to the merge queue Jul 1, 2024
github-merge-queue bot pushed a commit that referenced this pull request Jul 1, 2024
fix(engine): `Concrete_ident_generated`: `name` -> `t`, derive more
@W95Psp W95Psp removed this pull request from the merge queue due to a manual request Jul 1, 2024
@W95Psp W95Psp force-pushed the refactor-concrete-ident-generated branch from cc4d0cb to d7cdcc8 Compare July 1, 2024 11:31
@W95Psp W95Psp enabled auto-merge July 1, 2024 11:31
@W95Psp W95Psp added this pull request to the merge queue Jul 1, 2024
Merged via the queue into main with commit 7be21f5 Jul 1, 2024
13 checks passed
@W95Psp W95Psp deleted the refactor-concrete-ident-generated branch July 1, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-on-reviewer Status: Awaiting review from the assignee but also interested parties.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants