Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move book from hacspec/book to hacspec/hax #729

Merged
merged 8 commits into from
Jul 1, 2024
Merged

Move book from hacspec/book to hacspec/hax #729

merged 8 commits into from
Jul 1, 2024

Conversation

W95Psp
Copy link
Collaborator

@W95Psp W95Psp commented Jun 20, 2024

Fixes #725

franziskuskiefer
franziskuskiefer requested changes Jun 21, 2024
View reviewed changes
Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the theme directory actually needed? I don't think we use a special theme.

book/.github/workflows/gh-pages.yml Outdated Show resolved Hide resolved
.github/workflows/gh_pages.yml Show resolved Hide resolved
@franziskuskiefer franziskuskiefer added the waiting-on-author Status: This is awaiting some action from the author. label Jun 21, 2024
@W95Psp W95Psp requested a review from franziskuskiefer June 21, 2024 07:54
@W95Psp W95Psp added waiting-on-reviewer Status: Awaiting review from the assignee but also interested parties. and removed waiting-on-author Status: This is awaiting some action from the author. labels Jun 21, 2024
@W95Psp W95Psp force-pushed the move-book branch 11 times, most recently from f94b684 to 01237ca Compare July 1, 2024 08:39
@W95Psp W95Psp enabled auto-merge July 1, 2024 08:54
@W95Psp W95Psp added this pull request to the merge queue Jul 1, 2024
github-merge-queue bot pushed a commit that referenced this pull request Jul 1, 2024
@W95Psp
Merge pull request #729 from hacspec/move-book
6e1fb31 
Move book from `hacspec/book` to `hacspec/hax`
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jul 1, 2024
@W95Psp W95Psp enabled auto-merge July 1, 2024 10:58
@W95Psp W95Psp added this pull request to the merge queue Jul 1, 2024
Merged via the queue into main with commit 0da8372 Jul 1, 2024
13 checks passed
@W95Psp W95Psp deleted the move-book branch July 1, 2024 11:30
@W95Psp W95Psp mentioned this pull request Jul 1, 2024
Draft
W95Psp added a commit that referenced this pull request Jul 16, 2024
@W95Psp
feat(book): fix checkboxes
e436991 
The book uses custom checkboxes in the quickstart chapter. When we
moved the book to this repo (see
#729), we dropped the theme.

mdbook documentation suggest (see
https://rust-lang.github.io/mdBook/format/theme/index.html) copying
and patching the default theme.

Since here it's such a small change, I added a small script that
post-process the HTML instead.
@W95Psp W95Psp mentioned this pull request Jul 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franziskuskiefer franziskuskiefer franziskuskiefer approved these changes

Assignees
No one assigned
Labels
waiting-on-reviewer Status: Awaiting review from the assignee but also interested parties.
Projects
No open projects
hax
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move hacspec/book into the main repo
2 participants
@W95Psp @franziskuskiefer