implement review remarks

hadronlabs-org · Nov 22, 2024 · 89258d4 · 89258d4
1 parent e52d771
commit 89258d4
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/contracts/val-ref/src/contract.rs b/contracts/val-ref/src/contract.rs
@@ -188,7 +188,11 @@ pub fn query(deps: Deps<NeutronQuery>, _env: Env, msg: QueryMsg) -> ContractResu
 #[cfg_attr(not(feature = "library"), cosmwasm_std::entry_point)]
 pub fn reply(_deps: DepsMut, _env: Env, msg: Reply) -> ContractResult<Response> {
     match msg.id {
-        EDIT_ON_TOP_REPLY_ID => Ok(Response::new()),
+        EDIT_ON_TOP_REPLY_ID => Ok(response(
+            "reply",
+            CONTRACT_NAME,
+            [attr("edit_on_top_error", true.to_string())],
+        )),
         id => Err(ContractError::UnknownReplyId { id }),
     }
 }

diff --git a/contracts/validators-set/src/contract.rs b/contracts/validators-set/src/contract.rs
@@ -140,7 +140,7 @@ fn execute_update_validators(
 
     let total_count = validators.len();
 
-let old_validator_set: HashMap<String, ValidatorInfo> = VALIDATORS_SET
+    let old_validator_set: HashMap<String, ValidatorInfo> = VALIDATORS_SET
         .range_raw(deps.storage, None, None, Order::Ascending)
         .map(|item| item.map(|(_key, value)| (value.valoper_address.to_string(), value)))
         .collect::<StdResult<_>>()?;