Feat/remove default values #109
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faust403
force-pushed
the
feat/remove-default-values
branch
from
7aa282b to
c01e934
Compare
albertandrejev
force-pushed
the
feat/deploy-script
branch
from
2a74f8a to
b8cb35d
Compare
scripts/deploy_scripts/utils.bash
Outdated
Comment on lines
172
to
177
| "lsm_redeem_threshold":2, | ||
| "lsm_min_bond_amount":"1", | ||
| "lsm_redeem_max_interval":60000, | ||
| "bond_limit":"0", | ||
| "min_stake_amount":"2", | ||
| "icq_update_delay": 5 |
There was a problem hiding this comment.
Please replace these default values with variables as well
scripts/deploy_scripts/utils.bash
Outdated
| }, | ||
| "base_denom":"'"$uatom_on_neutron_denom"'", | ||
| "core_params":{ | ||
| "idle_min_interval":60, |
scripts/deploy_scripts/utils.bash
Outdated
| "transfer_channel_id":"'"$NEUTRON_SIDE_TRANSFER_CHANNEL_ID"'", | ||
| "port_id":"transfer", | ||
| "denom":"'"$TARGET_BASE_DENOM"'", | ||
| "update_period":100 |
scripts/deploy_scripts/utils.bash
Outdated
Comment on lines
160
to
164
| "description":"Drop token", | ||
| "display":"drop", | ||
| "exponent":6, | ||
| "name":"Drop liquid staking token", | ||
| "symbol":"DROP" |
There was a problem hiding this comment.
This values as well, but set default value to the current constant
scripts/deploy_scripts/utils.bash
Outdated
Comment on lines
180
to
181
| "min_stake_amount":"10000", | ||
| "min_ibc_transfer":"10000", |
…ate.bash and update .env.instantiate.example
albertandrejev
requested changes
Jul 9, 2024
albertandrejev
approved these changes
Jul 9, 2024
ratik
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.