feat: LIDO-76. Strategy contract #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertandrejev
changed the base branch from
main
to
feat/LIDO-75-validator-set
albertandrejev
force-pushed
the
feat/LIDO-76-strategy-contract
branch
3 times, most recently
from
3e8b226 to
3a5b908
Compare
albertandrejev
force-pushed
the
feat/LIDO-76-strategy-contract
branch
from
3a5b908 to
ee8b76e
Compare
ratik
reviewed
Jan 12, 2024
ratik
reviewed
Jan 15, 2024
contracts/strategy/src/contract.rs
Outdated
Comment on lines
134
to
142
| let validator_denom_delegation = account_delegations | ||
| .delegations | ||
| .iter() | ||
| .find(|delegation| { | ||
| delegation.validator == validator.valoper_address | ||
| && delegation.amount.denom == denom | ||
| }) | ||
| .map(|delegation| delegation.amount.amount) | ||
| .unwrap_or_default(); |
There was a problem hiding this comment.
not critical: it would be a bit optimal ( O(N^2) -> O(N) ) to prepare set of delegations into a Map<String, UInt128> before this cycle
ratik
reviewed
Jan 15, 2024
|
|
||
| use lido_staking_base::{ | ||
| msg::validatorsstats::{ExecuteMsg, InstantiateMsg, MigrateMsg}, | ||
| state::validatorsstats::QueryMsg, |
There was a problem hiding this comment.
let's move messages into messages
oldremez
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hadronlabs.atlassian.net/browse/LIDO-76