add ICQ for unbonding queue #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foxpy
force-pushed
the
feat/LIDO-85-query-unbonding-queue
branch
3 times, most recently
from
6b5f872 to
3538a83
Compare
foxpy
force-pushed
the
feat/LIDO-85-query-unbonding-queue
branch
3 times, most recently
from
ce5fe98 to
bba5ab8
Compare
foxpy
force-pushed
the
feat/LIDO-85-query-unbonding-queue
branch
2 times, most recently
from
29da5f6 to
03cc1c3
Compare
foxpy
force-pushed
the
feat/LIDO-85-query-unbonding-queue
branch
from
03cc1c3 to
830eec5
Compare
contracts/puppeteer/src/contract.rs
Outdated
| }, | ||
| )?; | ||
|
|
||
| response = response.add_submessage(SubMsg::reply_on_success( |
There was a problem hiding this comment.
You can add all submessages to one vector with type Vec<SubMsg<NeutronMsg>> and attach them in response using add_submessages. In this case there will be no need need line 295.
There was a problem hiding this comment.
I will still have to define this vector of messages instead of response.
I will check out if I can collect these messages into a vector using iterators only. If not, I don't think we can refactor this
There was a problem hiding this comment.
In this case you will not be required to mutate response every time
packages/helpers/src/query_id.rs
Outdated
There was a problem hiding this comment.
nice, I did the same in my PR :)
albertandrejev
approved these changes
Feb 14, 2024
ratik
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.