-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: LIDO-87. Rewards manager #25
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s into feat/core-fsm
Interceptor > puppeteer + single action puppeteer
feat: fsm + claiming + staking + transfering + etc
ratik
reviewed
Feb 8, 2024
tx.json
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably shouldn't be here
funds: vec![balance], | ||
}); | ||
|
||
res = res |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's cheaper and more readable to collect messages and attributes and after the cycle have add_messages and add_attributes
Co-authored-by: Sergey R <[email protected]>
Co-authored-by: Sergey R <[email protected]>
albertandrejev
force-pushed
the
feat/LIDO-87-rewards-manager
branch
from
February 9, 2024 10:26
fb49422
to
95a9d4c
Compare
ratik
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rewards manager has a list of supported denoms (e.g. NTRN, STRD, USDC) and target denom (e.g. ATOM or DYDX). It assumes that it receives “proper” denoms (router through the proper IBC route). It has a permissionless handler that swaps supported denoms into a target one on Astroport and sends it to core contract (via “AddRewards” msg)