Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't signal fence and flush in renderer, let user control it #67

Merged
merged 1 commit into from
Mar 23, 2024

Conversation

hakolao
Copy link
Owner

@hakolao hakolao commented Mar 23, 2024

hmmm... might be even better to just return the command buffer...

@hakolao hakolao merged commit c4f59f0 into master Mar 23, 2024
3 of 4 checks passed
@hakolao hakolao deleted the dont-signal-fence-and-flush-in-renderer branch March 23, 2024 11:20
@RA3236
Copy link

RA3236 commented Mar 23, 2024

There are a couple of other times in the code where a command buffer is submitted and executed mid-frame (notably Renderer::update_textures()). What could probably work better is having a single secondary command buffer that is passed to each function and relying on the user to wait() when necessary, but I would reckon that #52 should be merged once vulkano is updated before doing major changes like that.

@hakolao
Copy link
Owner Author

hakolao commented Mar 23, 2024

True

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants