-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates dockerlizard and cMake -- fixes #68 #66
base: master
Are you sure you want to change the base?
Conversation
Looking at the diff, it looks like you copied for instance: I might be wrong, but I think you don't want |
yep, deleted them -- thanks! |
1de94c2
to
f4c6abd
Compare
@halbux @Drinausaur I think I fixed the excessive files issue: you can ignore everything in |
I don't think it is fixed. I'm pretty sure you're still having some duplicates: In doubt, look at the diff GitHub offers. There should not be that many files with a "+", if you only moved some files. PS: I am not a maintainer or anything on that repo, I only stumbled upon your MR and looked at it because I was interested ^^ |
6c0986b
to
2f9a120
Compare
OK I think this got fixed -- annoying issues with rsync. Everything in |
128dc38
to
d477f5f
Compare
d477f5f
to
2b5518c
Compare
The existing docker build and cmake build were not really using cmake to its fullest. This creates and builds
libsparselizard.so
and has a Dockerfile that'll install it to a GNU-style directory tree in/usr/local
You can override where it finds libraries by changing the
CMAKE_PREFIX_PATH
(orCMAKE_INCLUDE_PATH
+CMAKE_LIBRARY_PATH
) to wherever your custom libs and includes are.LD_LIBRARY_PATH
orRPATH
would need to change for runtime loading.In addition, this makes it possible to cleanly build using system libs on both macOS and linux, which will make it much easier for
sparselizard
to be packaged into distributions.The docker container that is built is barebones, but it is still good enough to allow for VS Code "remote container" style development. It's best used as a starting point for customization.
Effectively supersedes #50