Drop deprecated / unsupported setups for Halide 20 #8508
Conversation
|
Looks like there are some new helpful clang-tidy failures. Feel free to fix in this PR or a follow-up if you feel that would be cleaner. I'm also happy to fix in a follow up if you're slammed today. |
Sounds like @steven-johnson is eager to fix in a follow up PR |
If we are generating untidy code, would be nice to open an issue to fix that someday |
alexreinking
force-pushed
the
drop-deprecations
branch
from
984b324 to
be98823
Compare
Lots of warnings where it wants us to write |
|
These failures are quite strange. Will need to investigate. |
|
FWIW I think I'm seeing the same failures here: #8518 |
In that case, looks like an LLVM 20 injection? |
This PR drops support for LLVM 17 according to our support policy. It also drops the old names for CMake variables that were renamed and deprecated between Halide 18 and 19.
We also take this opportunity to bump clang-tidy from version 17 to 19. A subsequent PR will do the same for clang-format (so we have a consistent set of tools).