Upgrade to clang-format 19 #8543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexreinking
force-pushed
the
clang-format-19
branch
from
2bd7353 to
b308a0e
Compare
abadams
reviewed
Dec 29, 2024
src/IRMatch.h
Outdated
| base.template match<bound | bindings<Vec>::mask>(v.slice_begin(), state) && | ||
| stride.template match<bound | bindings<Vec>::mask | bindings<Base>::mask>(v.slice_stride(), state) && | ||
| lanes.template match<bound | bindings<Vec>::mask | bindings<Base>::mask | bindings<Stride>::mask>(v.type.lanes(), state); | ||
| base.template match < bound | bindings<Vec>::mask > (v.slice_begin(), state) && |
There was a problem hiding this comment.
This is fine I guess, but I'm wondering if some parens would work, just in case it's something about bitwise or having lower precedence than a comparison like <
base.template match<(bound | bindings<Vec>::mask)>(v.slice_begin(), state)
There was a problem hiding this comment.
It does like the parentheses better, and so do I
abadams
reviewed
Dec 29, 2024
src/runtime/HalideBuffer.h
Outdated
| HALIDE_ALWAYS_INLINE | ||
| storage_T * | ||
| address_of(Args... args) const { | ||
| HALIDE_ALWAYS_INLINE storage_T * |
There was a problem hiding this comment.
imo if this is now two lines, it would be better with the return type on the second line instead of the first.
There was a problem hiding this comment.
It wouldn't let me break there, but it seems happy with everything on one line, which is fine in this case. If I put a // break after HALIDE_ALWAYS_INLINE, it still insists on breaking after storage_T *.
|
Ready to land? |
abadams
approved these changes
Jan 2, 2025
steven-johnson
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to clang-format 19 and apply the tool to the codebase. There are three main groups of changes:
IRMatch.hI updated the
.clang-formatfile to replace deprecated options with their supported counterparts. I also removed penalty tweaks that didn't do anything.Clang format 19 is more willing to remove line breaks with
ColumnLimit: 0than before. It does a particularly bad job with lambda arguments (as can be seen in the Python bindings). I found it necessary to add a trailing comment to the last line of each lambda.