added evaluation for multiple images #1709
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is a function
eval_model(args)
inrun_llava.py
that permit us to query a single image (although theoreticallyimage_parser
return us a list andprocess_images
also receives a list). The problem is thatprocess_images
(inmm_utils.py
) makes a new listnew_images
but then due to line 181 of the codenew_images = torch.stack(new_images, dim=0)
produce that only the first image is processed.Therefore I wrote the function
eval_multiple
that permits the evaluation of multiple images.For example we use it like this
I also add a function to
conversation.py
that permit us get a copy of the conversation, so that we can modify the system prompt of the conversation if we wish.