Issue fixed Suggestion of refactorizing code #7

.classpath

@@ -0,0 +1,7 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<classpath>
+	<classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER"/>
+	<classpathentry kind="src" path="Project/src"/>
+	<classpathentry kind="lib" path="Project/derbyclient-10.2.2.0.jar"/>
+	<classpathentry kind="output" path="Project/build/classes"/>
+</classpath>

.project

@@ -0,0 +1,17 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<projectDescription>
+	<name>Library-Management-System-JAVA-master</name>
+	<comment></comment>
+	<projects>
+	</projects>
+	<buildSpec>
+		<buildCommand>
+			<name>org.eclipse.jdt.core.javabuilder</name>
+			<arguments>
+			</arguments>
+		</buildCommand>
+	</buildSpec>
+	<natures>
+		<nature>org.eclipse.jdt.core.javanature</nature>
+	</natures>
+</projectDescription>

Library-Management-System-JAVA-master.iml

@@ -0,0 +1,11 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<module type="JAVA_MODULE" version="4">
+  <component name="NewModuleRootManager" inherit-compiler-output="true">
+    <exclude-output />
+    <content url="file://$MODULE_DIR$">
+      <sourceFolder url="file://$MODULE_DIR$/Project/src" isTestSource="false" />
+    </content>
+    <orderEntry type="inheritedJdk" />
+    <orderEntry type="sourceFolder" forTests="false" />
+  </component>
+</module>

Project/nbproject/genfiles.properties

@@ -1,8 +1,8 @@
 build.xml.data.CRC32=507ddfa4
 build.xml.script.CRC32=5d5937f5
-build.xml.stylesheet.CRC32=8064a381@1.80.1.48
+build.xml.stylesheet.CRC32=f85dc8f2@1.106.0.48
 # This file is used by a NetBeans-based IDE to track changes in generated files such as build-impl.xml.
 # Do not edit this file. You may delete it but then the IDE will never regenerate such files for you.
 nbproject/build-impl.xml.data.CRC32=507ddfa4
-nbproject/build-impl.xml.script.CRC32=0ebf329b
-nbproject/build-impl.xml.stylesheet.CRC32=830a3534@1.80.1.48
+nbproject/build-impl.xml.script.CRC32=0eec8d9b
+nbproject/build-impl.xml.stylesheet.CRC32=12e0a6c2@1.106.0.48

Project/nbproject/private/private.properties

@@ -3,4 +3,4 @@ do.depend=false
 do.jar=true
 javac.debug=true
 javadoc.preview=true
-user.properties.file=C:\\Users\\PAKLAP.pk\\AppData\\Roaming\\NetBeans\\8.2\\build.properties
+user.properties.file=C:\\Users\\2106802\\AppData\\Roaming\\NetBeans\\17\\build.properties

Project/nbproject/private/private.xml

@@ -3,7 +3,14 @@
     <editor-bookmarks xmlns="http://www.netbeans.org/ns/editor-bookmarks/2" lastBookmarkId="0"/>
     <open-files xmlns="http://www.netbeans.org/ns/projectui-open-files/2">
         <group>
-            <file>file:/D:/FAST/5th%20Semester%20%20%20%20(Fall%202017)/Object%20Oriented%20Analysis%20and%20Design/Assignments/Assignment%201/Library%20Management%20System/Project/src/LMS/Main.java</file>
+            <file>file:/C:/Users/2106802/Downloads/Library-Management-System-JAVA-master/Project/src/LMS/HoldRequestOperations.java</file>
+            <file>file:/C:/Users/2106802/Downloads/Library-Management-System-JAVA-master/Project/src/LMS/Book.java</file>
+            <file>file:/C:/Users/2106802/Downloads/Library-Management-System-JAVA-master/Project/src/LMS/Main.java</file>
+            <file>file:/C:/Users/2106802/Downloads/Library-Management-System-JAVA-master/Project/src/LMS/HoldRequest.java</file>
+            <file>file:/C:/Users/2106802/Downloads/Library-Management-System-JAVA-master/Project/src/LMS/Library.java</file>
+            <file>file:/C:/Users/2106802/Downloads/Library-Management-System-JAVA-master/Project/src/LMS/Librarian.java</file>
+            <file>file:/C:/Users/2106802/Downloads/Library-Management-System-JAVA-master/Project/src/LMS/HoldRequestActions.java</file>
+            <file>file:/C:/Users/2106802/Downloads/Library-Management-System-JAVA-master/Project/src/LMS/Borrower.java</file>
         </group>
     </open-files>
 </project-private>

Project/nbproject/project.properties

@@ -19,8 +19,12 @@ build.test.results.dir=${build.dir}/test/results
 #debug.transport=dt_socket
 debug.classpath=\
     ${run.classpath}
+debug.modulepath=\
+    ${run.modulepath}
 debug.test.classpath=\
     ${run.test.classpath}
+debug.test.modulepath=\
+    ${run.test.modulepath}
 # Files in build.classes.dir which should be excluded from distribution jar
 dist.archive.excludes=
 # This directory is removed when the project is cleaned:
@@ -29,22 +33,26 @@ dist.jar=${dist.dir}/Library_Management_System.jar
 dist.javadoc.dir=${dist.dir}/javadoc
 endorsed.classpath=
 excludes=
-file.reference.derbyclient-10.2.2.0.jar=derbyclient-10.2.2.0.jar
+file.reference.mysql-connector-j-8.3.0.jar=C:\\Users\\2106802\\Downloads\\mysql-connector-j-8.3.0\\mysql-connector-j-8.3.0.jar
 includes=**
 jar.compress=false
 javac.classpath=\
-    ${file.reference.derbyclient-10.2.2.0.jar}
+    ${file.reference.mysql-connector-j-8.3.0.jar}
 # Space-separated list of extra javac options
 javac.compilerargs=
 javac.deprecation=false
 javac.external.vm=true
+javac.modulepath=
+javac.processormodulepath=
 javac.processorpath=\
     ${javac.classpath}
 javac.source=1.8
 javac.target=1.8
 javac.test.classpath=\
     ${javac.classpath}:\
     ${build.classes.dir}
+javac.test.modulepath=\
+    ${javac.modulepath}
 javac.test.processorpath=\
     ${javac.test.classpath}
 javadoc.additionalparam=
@@ -70,9 +78,13 @@ run.classpath=\
 # You may also define separate properties like run-sys-prop.name=value instead of -Dname=value.
 # To set system properties for unit tests define test-sys-prop.name=value:
 run.jvmargs=
+run.modulepath=\
+    ${javac.modulepath}
 run.test.classpath=\
     ${javac.test.classpath}:\
     ${build.test.classes.dir}
+run.test.modulepath=\
+    ${javac.test.modulepath}
 source.encoding=UTF-8
 src.dir=src
 test.src.dir=test

Project/src/LMS/Book.java

@@ -12,7 +12,7 @@ public class Book {
     private String subject;       // Subject to which a book is related!
     private String author;        // Author of book!
     private boolean isIssued;        // this will be true if the book is currently issued to some borrower.
-    private HoldRequestOperations holdRequestsOperations =new HoldRequestOperations();
+    private HoldRequestOperations holdRequests;
     static int currentIdNumber = 0;     //This will be unique for every book, since it will be incremented when everytime
                                         //when a book is created
 
@@ -31,25 +31,26 @@ public Book(int id,String t, String s, String a, boolean issued)    // Parameter
         subject = s;
         author = a;
         isIssued = issued;
+        this.holdRequests = holdRequests;
 
     }
 
 
     // printing all hold req on a book.
     public void printHoldRequests()
     {
-        if (!holdRequestsOperations.holdRequests.isEmpty())
+        if (!holdRequests.holdRequests.isEmpty())
         { 
             System.out.println("\nHold Requests are: ");
 
             System.out.println("---------------------------------------------------------------------------------------------------------------------------------------");            
             System.out.println("No.\t\tBook's Title\t\t\tBorrower's Name\t\t\tRequest Date");
             System.out.println("---------------------------------------------------------------------------------------------------------------------------------------");
 
-            for (int i = 0; i < holdRequestsOperations.holdRequests.size(); i++)
+            for (int i = 0; i < holdRequests.holdRequests.size(); i++)
             {                      
                 System.out.print(i + "-" + "\t\t");
-                holdRequestsOperations.holdRequests.get(i).print();
+                holdRequests.holdRequests.get(i).print();
             }
         }
         else
@@ -135,7 +136,7 @@ public int getID()
 
      public ArrayList<HoldRequest> getHoldRequests()
     {
-        return holdRequestsOperations.holdRequests;
+        return holdRequests.holdRequests;
     }
     /*-----------------------------------*/
 
@@ -155,7 +156,7 @@ public void placeBookOnHold(Borrower bor)
     {
         HoldRequest hr = new HoldRequest(bor,this, new Date());
 
-        holdRequestsOperations.addHoldRequest(hr);        //Add this hold request to holdRequests queue of this book
+        holdRequests.addHoldRequest(hr);        //Add this hold request to holdRequests queue of this book
         bor.addHoldRequest(hr);      //Add this hold request to that particular borrower's class as well
 
         System.out.println("\nThe book " + title + " has been successfully placed on hold by borrower " + bor.getName() + ".\n");
@@ -181,9 +182,9 @@ public void makeHoldRequest(Borrower borrower)
 
 
         //If that borrower has already requested for that particular book. Then he isn't allowed to make the same request again.
-        for (int i = 0; i < holdRequestsOperations.holdRequests.size(); i++)
+        for (int i = 0; i < holdRequests.holdRequests.size(); i++)
         {
-            if ((holdRequestsOperations.holdRequests.get(i).getBorrower() == borrower))
+            if ((holdRequests.holdRequests.get(i).getBorrower() == borrower))
             {
                 makeRequest = false;    
                 break;
@@ -202,7 +203,7 @@ public void makeHoldRequest(Borrower borrower)
     // Getting Info of a Hold Request
     public void serviceHoldRequest(HoldRequest hr)
     {
-        holdRequestsOperations.removeHoldRequest();
+        holdRequests.removeHoldRequest();
         hr.getBorrower().removeHoldRequest(hr);
     }
 
@@ -214,7 +215,7 @@ public void issueBook(Borrower borrower, Staff staff)
         //First deleting the expired hold requests
         Date today = new Date();        
 
-        ArrayList<HoldRequest> hRequests = holdRequestsOperations.holdRequests;
+        ArrayList<HoldRequest> hRequests = holdRequests.holdRequests;
 
         for (int i = 0; i < hRequests.size(); i++)
         {
@@ -226,7 +227,7 @@ public void issueBook(Borrower borrower, Staff staff)
 
             if(days>Library.getInstance().getHoldRequestExpiry())
             {
-                holdRequestsOperations.removeHoldRequest();
+                holdRequests.removeHoldRequest();
                 hr.getBorrower().removeHoldRequest(hr);
             } 
         }
@@ -247,22 +248,22 @@ public void issueBook(Borrower borrower, Staff staff)
 
         else
         {               
-            if (!holdRequestsOperations.holdRequests.isEmpty())
+            if (!holdRequests.holdRequests.isEmpty())
             {
                 boolean hasRequest = false;
 
-                for (int i = 0; i < holdRequestsOperations.holdRequests.size() && !hasRequest;i++)
+                for (int i = 0; i < holdRequests.holdRequests.size() && !hasRequest;i++)
                 {
-                    if (holdRequestsOperations.holdRequests.get(i).getBorrower() == borrower)
+                    if (holdRequests.holdRequests.get(i).getBorrower() == borrower)
                         hasRequest = true;
 
                 }
 
                 if (hasRequest)
                 {
                     //If this particular borrower has the earliest request for this book
-                    if (holdRequestsOperations.holdRequests.get(0).getBorrower() == borrower)
-                        serviceHoldRequest(holdRequestsOperations.holdRequests.get(0));
+                    if (holdRequests.holdRequests.get(0).getBorrower() == borrower)
+                        serviceHoldRequest(holdRequests.holdRequests.get(0));
 
                     else
                     {

Project/src/LMS/HoldRequestActions.java

@@ -0,0 +1,21 @@
+/*
+ * Click nbfs://nbhost/SystemFileSystem/Templates/Licenses/license-default.txt to change this license
+ * Click nbfs://nbhost/SystemFileSystem/Templates/Classes/Interface.java to edit this template
+ */
+package LMS;
+
+/**
+ *
+ * @author 2106802
+ */
+public interface HoldRequestActions {
+
+    public void addHoldRequest(HoldRequest hr);
+
+public void removeHoldRequest (HoldRequest hr); public void removeHoldRequest();
+
+public void printHoldRequest();
+
+public void serviceHoldRequest(HoldRequest hr);
+
+}

Project/src/LMS/HoldRequestOperations.java

@@ -2,7 +2,7 @@
 
 import java.util.ArrayList;
 
-public class HoldRequestOperations {
+public class HoldRequestOperations implements HoldRequestActions {
 
    static ArrayList <HoldRequest> holdRequests;
 
@@ -23,4 +23,19 @@ public void removeHoldRequest()
             holdRequests.remove(0);
         }
     }
+
+    @Override
+    public void removeHoldRequest(HoldRequest hr) {
+        throw new UnsupportedOperationException("Not supported yet."); // Generated from nbfs://nbhost/SystemFileSystem/Templates/Classes/Code/GeneratedMethodBody
+    }
+
+    @Override
+    public void printHoldRequest() {
+        throw new UnsupportedOperationException("Not supported yet."); // Generated from nbfs://nbhost/SystemFileSystem/Templates/Classes/Code/GeneratedMethodBody
+    }
+
+    @Override
+    public void serviceHoldRequest(HoldRequest hr) {
+        throw new UnsupportedOperationException("Not supported yet."); // Generated from nbfs://nbhost/SystemFileSystem/Templates/Classes/Code/GeneratedMethodBody
+    }
 }

Project/src/LMS/Library.java

@@ -599,12 +599,24 @@ public Connection makeConnection()
     {        
         try
         {
-            String host = "jdbc:derby://localhost:1527/LMS";
-            String uName = "haris";
-            String uPass= "123";
+           // try {
+                //String host = "jdbc:derby://localhost:3306/LMS";
+                //String uName = "haris";
+                //String uPass= "123";
+
+                Class.forName("com.mysql.cj.jdbc.Driver");
+            //} catch (ClassNotFoundException ex) {
+               // Logger.getLogger(Library.class.getName()).log(Level.SEVERE, null, ex);
+            String host = "jdbc:mysql://localhost:3306/LMS";
+            String uName = "root";
+            String uPass= "admin";
             Connection con = DriverManager.getConnection( host, uName, uPass );
             return con;
         }
+        catch (ClassNotFoundException ex) {
+                Logger.getLogger(Library.class.getName()).log(Level.SEVERE, null, ex);
+           return null;
+        }
         catch ( SQLException err ) 
         {
             System.out.println( err.getMessage( ) );