This repository has been archived by the owner on Feb 23, 2022. It is now read-only.
18: fix locale issues with printing using std::to_string for floats #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexmercerind
approved these changes
Jan 7, 2022
There was a problem hiding this comment.
I had idea from the very start that this was eventually going to break for some becaue of , being used as decimal in some locales. However, I still didn't bother too much in hurry.
I assume this would work, merging. Would revert/fix commit in-case I find this breaking.
Thanks for the contribution 🥳.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18
std::to_string output depends on the locale on the machine it happens to be running on. For floats, this produces invalid output with comma instead of period as a decimal separator, such as
0,3instead of0.3.