Handling of the offset parameter for the ols, lrm, Glm functions #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… changed the name to offset from offs as to the variable is now a parameter
|
Sorry for all the updates, just thought that it might be useful to look at the test-cases that I added to my fork: https://github.com/gforge/rms/tree/master/tests/testthat I've tried to think of most possible use-cases where the offset term may cause issues. I've still not yet implemented a summary() test; I tried to test against the confint() but the summary confidence intervals seem to be slightly different (probably a feature that I have missed). I also use the testthat-package which I've found very convenient for setting up automated tests. If you want to start using it for your package you need to add a testthat.R file directly under the tests catalog. |
…as a single variable
Merge branch 'master' of https://github.com/harrelfe/rms Conflicts: R/lrm.s man/lrm.Rd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok, here are my fixes that seem to correct some of the remaining offset issues.
/Max