Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure EPUB generation work #112

Merged
merged 14 commits into from
Dec 11, 2023

Conversation

V0XNIHILI
Copy link
Contributor

@V0XNIHILI V0XNIHILI commented Dec 10, 2023

Resolves #83. I hope to have this working tomorrow! For now, running into issues with the formats of some images.

Before submitting your Pull Request, please ensure that you have carefully reviewed and completed all items on this checklist.

  1. Quarto Website Rendering

    • The chapter has been locally built and tested using Quarto.
  2. Final Steps

    • The Pull Request is made with a clear title and description.
    • The Pull Request includes any necessary labels or tags.
    • The Pull Request mentions any stakeholders or reviewers who should take a look.

@V0XNIHILI V0XNIHILI marked this pull request as ready for review December 10, 2023 22:10
@V0XNIHILI V0XNIHILI marked this pull request as draft December 10, 2023 22:10
@profvjreddi
Copy link
Contributor

Looking forward to it 🙌

@V0XNIHILI V0XNIHILI changed the title [work in progress] Make sure EPUB and PDF generation work [work in progress] Make sure EPUB generation work Dec 11, 2023
@V0XNIHILI
Copy link
Contributor Author

V0XNIHILI commented Dec 11, 2023

I will not proceed with adding PDF support, it is proving to be too hard as there are many constructs that work fine in EPUB and HTML but not in the PDF. Examples include:

  • Citing references in captions
  • Sometimes, arbitrary jpg and png figures are not supported by XeTeX...
  • .webp figures (although I already fixed this)
  • SVG images (need extra conversion step using Inkscape), used here for example:
image

@V0XNIHILI V0XNIHILI marked this pull request as ready for review December 11, 2023 10:44
@V0XNIHILI V0XNIHILI mentioned this pull request Dec 11, 2023
@V0XNIHILI V0XNIHILI changed the title [work in progress] Make sure EPUB generation work Make sure EPUB generation work Dec 11, 2023
@profvjreddi
Copy link
Contributor

OK let's not worry about the PDF then. I was also told that we have to fix our figures etc. quite a bit to make it work well. We can work on that in the future. Thanks for trying @V0XNIHILI

@profvjreddi profvjreddi reopened this Dec 11, 2023
@profvjreddi profvjreddi merged commit 43ebba1 into harvard-edge:main Dec 11, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Download of book on website doesn't work
2 participants