Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

366 labs raspi support - format and text review #422

Merged

Conversation

Mjrovai
Copy link
Contributor

@Mjrovai Mjrovai commented Aug 30, 2024

Before submitting your Pull Request, please ensure that you have carefully reviewed and completed all items on this checklist.

  1. Content

    • [ x] The chapter content is complete and covers the topic in detail.
    • [x ] All technical terms are well-defined and explained.
    • [x ] Any code snippets or algorithms are well-documented and tested.
    • [x ] The chapter follows a logical flow and structure.
  2. References & Citations

    • All references are correctly listed at the end of the chapter.
    • In-text citations are used appropriately and match the references.
    • All figures, tables, and images have proper sources and are cited correctly.
  3. Quarto Website Rendering

    • [x ] The chapter has been locally built and tested using Quarto.
    • [x ] All images, figures, and tables render properly without any glitches.
    • All images have a source or they are properly linked to external sites.
    • Any interactive elements or widgets work as intended.
    • [x ] The chapter's formatting is consistent with the rest of the book.
  4. Grammar & Style

    • [x ] The chapter has been proofread for grammar and spelling errors.
    • [x ] The writing style is consistent with the rest of the book.
    • [x ] Any jargon is clearly explained or avoided where possible.
  5. Collaboration

    • All group members have reviewed and approved the chapter.
    • Any feedback from previous reviews or discussions has been addressed.
  6. Miscellaneous

    • [x ] All external links (if any) are working and lead to the intended destinations.
    • If datasets or external resources are used, they are properly credited and linked.
    • Any necessary permissions for reused content have been obtained.
  7. Final Steps

    • [x ] The chapter is pushed to the correct branch on the repository.
    • [x ] The Pull Request is made with a clear title and description.
    • The Pull Request includes any necessary labels or tags.
    • The Pull Request mentions any stakeholders or reviewers who should take a look.

Sara-Khosravi and others added 30 commits July 11, 2024 17:01
Enhancements and Revisions to efficient_ai.qmd with Professor Vijay's Feedback
…dback-chapter-eight

353 student feedback chapter eight
…t-in-hw_accelerationqmd

380 Self-evident in hw_acceleration.qmd
There are people who are generously contributing feedback in the form of GitHub issues but they aren't filing PRs. I want to acknowledge them as well cause they are critical to improving the material.
Adding @BravoBaldo as coauthor because he has been filing a lot of issues, and want to make sure I credit him under special thanks!

Co-authored-by: Baldassarre Cesarano <[email protected]>
…icient_aiqmd

389 Typo in efficient_ai.qmd
jasonjabbour and others added 23 commits August 26, 2024 02:44
…st-4-chapter-of-benchmarkingqmd

402 Note on first 4 chapter of "benchmarking.qmd"
…dback-chapter-9

Student Feedback Chapter 9
Trying out the sponsorship, first draft
Still figuring it out. Think its best to link it to Open Collective, so setting that up. In the mean time just removing this file.
…device_learningqmd

417 Notes In "ondevice_learning.qmd"
…e-first-part-of-opsqmd

419 Notes on the first part of "ops.qmd"
@Mjrovai
Copy link
Contributor Author

Mjrovai commented Aug 30, 2024

  • Changing code fence format (shell to bash)
  • Adding scrolling windows for long Python scripts in the HTML e-book version (style.scss)
  • Correcting a few typos

@profvjreddi profvjreddi merged commit 579f1b5 into harvard-edge:366-labs-raspi-support Sep 1, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants