Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency resolved and slight performance enhancements #12

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Dependency resolved and slight performance enhancements #12

wants to merge 11 commits into from

Commits on Aug 28, 2021

  1. Pin all dependencies explicitly 

    - This caused huge errors in form of tracebacks.
- Now all depencies are resolved.
- Removed duplicate dependencies between requirements.txt file
- Preprocessing works fine so the project is good to go.
    saadz-khan committed Aug 28, 2021
    Configuration menu
    Copy the full SHA
    f3aa59c View commit details
    Browse the repository at this point in the history

  2. Updated README.md 

    - All dependencies along with the python version mentioned.
- Dataset used and preprocessing steps mentioned.
- Config file alteration mentioned.
    saadz-khan committed Aug 28, 2021
    Configuration menu
    Copy the full SHA
    134de9f View commit details
    Browse the repository at this point in the history

  3. Config Files setup for CPU by default 

    - Changed GPU ranks so that CPU is used by default.
- Uncomment the gpu-ranks and according to the number of GPU's being used. Set world_size (1 for 1 GPU or CPU).
    saadz-khan committed Aug 28, 2021
    Configuration menu
    Copy the full SHA
    53ebe00 View commit details
    Browse the repository at this point in the history

  4. Config changes for Default CPU usage 

    - Defaulting to CPU rather then to GPU.
- Comment out the gpu_ranks variable in config and set world_size. (world_size 1 for 1 GPU or CPU)
    saadz-khan committed Aug 28, 2021
    Configuration menu
    Copy the full SHA
    362de16 View commit details
    Browse the repository at this point in the history

  5. Removed +1, Already done in line above 

    - Here adding +2 to any n_feats will crash our results.
    saadz-khan committed Aug 28, 2021
    Configuration menu
    Copy the full SHA
    81ee008 View commit details
    Browse the repository at this point in the history

  6. Handle failure to set CUDA device, fallback to CPU then

    saadz-khan committed Aug 28, 2021
    Configuration menu
    Copy the full SHA
    0c9598e View commit details
    Browse the repository at this point in the history

  7. Tensors to be bytes rather than bools

    saadz-khan committed Aug 28, 2021
    Configuration menu
    Copy the full SHA
    244bfaa View commit details
    Browse the repository at this point in the history

  8. Adding the script for converting .bin to .txt.src and txt.tgt

    saadz-khan committed Aug 28, 2021
    Configuration menu
    Copy the full SHA
    52fe683 View commit details
    Browse the repository at this point in the history

  9. Add time prints for each step

    saadz-khan committed Aug 28, 2021
    Configuration menu
    Copy the full SHA
    3019c54 View commit details
    Browse the repository at this point in the history

  10. Added Dependency for the data/data_convert.py script in the comments.

    saadz-khan committed Aug 28, 2021
    Configuration menu
    Copy the full SHA
    4863de8 View commit details
    Browse the repository at this point in the history

  11. README.md update Added colab notebook made-easy.ipynb 

    - .bin file creation from raw stories
- .bin to .txt.src and .txt.tgt
    saadz-khan committed Aug 28, 2021
    Configuration menu
    Copy the full SHA
    939fd32 View commit details
    Browse the repository at this point in the history