fix: download Button name and tooltip added #1441
Conversation
Signed-off-by: mariyaraj <[email protected]>
mariyaraj
force-pushed
the
HederaIssue1
branch
from
2c9712e to
3fb37ed
Compare
|
Please join a snapshot to your PR. |
Could you clarify what kind of snapshot you need? I am new here and I am not sure, what should I do? |
#1185 includes two screenshots ; could you include the same screenshots with the visual changes you are proposing. |
There was a problem hiding this comment.
#1185 includes two screenshots ; could you include the same screenshots with the visual changes you are proposing.
|
@ericleponner Here are screenshots after my changes: |
There was a problem hiding this comment.
Download Transaction Historyis long : we should replace it byDownload.Download Transaction Historyis fine fortitleattribute but cannot be hard-coded becauseDownloadButtonis re-used in other views and different contexts- so title / tooltip must be parameterized by adding a new prop to
DownloadButton(egbuttonTitle) - some tooltip text must be defined for other
DownloadButtonusage ; your proposals are welcome
- so title / tooltip must be parameterized by adding a new prop to
- when window width is small, we should hide
Downloadand keep the icon only (as it is today)Footerview (line 40) shows how to do that
There was a problem hiding this comment.
This is useful for record keeping and tax reporting. is a bit too much specific : remove it.
There was a problem hiding this comment.
- dialog titles are left-aligned everywhere so keep it left-aligned
- inline help text should be left-aligned too (we have other dialogs like this)
- remove
This is useful … - when possible we try to avoid specific CSS definitions and prefer to use Bulma style classes
- here you can probably achieve the same visual with
has-text-greyandmt-xclasses - and remove
dialog-title-containeranddialog-subtitle
- here you can probably achieve the same visual with
ericleponner
changed the title
|
@ericleponner Changes committed. Here the screenshots: |
Fix for #1185