Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed vcdl-864 #427

Merged
merged 5 commits into from
Jun 14, 2024
Merged

fixed vcdl-864 #427

merged 5 commits into from
Jun 14, 2024

Conversation

syedQuadri7
Copy link
Contributor

No description provided.

@syedQuadri7 syedQuadri7 requested a review from a team as a code owner June 13, 2024 20:21
Copy link
Contributor

@thomashashi thomashashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to put some comments in VCDL-846 - this looks fine, but also looks like it's just from a version 2 -> version 3 conversion, so I want to make sure I didn't miss the other fixes required for this ticket.

@@ -0,0 +1,39 @@
---
slug: setup-our-environment
id: ebj23ohhehzw
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take out all IDs, then good to go!

@@ -0,0 +1,39 @@
---
slug: setup-our-environment
id: ebj23ohhehzw
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
id: ebj23ohhehzw

@@ -0,0 +1,51 @@
---
slug: hello-terraform
id: e0tq7efazoo2
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
id: e0tq7efazoo2

Copy link
Contributor

@jennamwong jennamwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@syedQuadri7 syedQuadri7 merged commit a1b895d into main Jun 14, 2024
3 checks passed
@syedQuadri7 syedQuadri7 deleted the VCDL-864 branch June 14, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants