plugincontainer: Add debug mode #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a debug mode which does extra work to help diagnose why a plugin may have failed to start, and make it easier for users to re-run their plugins interactively to better understand their behaviour.
In particular, we disable the
AutoRemoveoption in the Docker SDK when debug is enabled, otherwise we may end up in a race with the container runtime to salvage debug information before the container is killed and cleaned up.We also only print environment variables in the diagnose notes if debug is enabled, as they could reasonably contain secrets the plugin needs to consume.