Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependencies & go version to resolve #465 #466

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

andrewesweet
Copy link

A relatively straightforward bumping of dependencies (in particular google.golang.org/api) resolved #465. The quota project set in the Application Default Credential remains unrespected, but the environment variable is now respected so the data sources are usable as a non-service-account user.

Bumping google.golang.org/api to the latest version in turn bumped golang.org/x/oauth2 which lead to errors when building with go 1.16:

internal\provider\provider.go:17:2: //go:build comment without // +build comment
go\pkg\mod\golang.org\x\[email protected]\oauth2.go:21:2: //go:build comment without // +build comment

I resolved this by bumping the go version to 1.19. Why that version? Arbitrarily because that is what is presently used by the google provider.

Unfortunately, I lack the dependencies needed to run a full regression test of the provider, so I am at the maintainers' mercy to support that.

@andrewesweet andrewesweet requested a review from a team as a code owner September 14, 2023 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using groups datasources fails with quota project error when authenticating as a non-service-account user
1 participant