getmodules: support tbz2 module archives
#36081
Open
+25
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `tbz2` extension, a shorthand for `tar.bz2`, is supported for downloading and handling compressed archives in go-getter, which already treats both `tbz2` and `tar.bz2` as using the same bzip2 decompressor. This commit adds support for the `tbz2` decompressor when fetching modules from a source. Signed-off-by: Bruno Schaatsbergen <[email protected]>
- Grouped decompressor extensions (bz2, gzip, xz, zip). - Grouped getters (protocol-based, cloud storage, version control, file-based). Signed-off-by: Bruno Schaatsbergen <[email protected]>
bschaatsbergen
commented
Nov 22, 2024
|
|
||
| // Bzip2 | ||
| "bz2": new(getter.Bzip2Decompressor), | ||
| "tbz2": new(getter.TarBzip2Decompressor), |
There was a problem hiding this comment.
For clarity, this tbz2 decompressor has been added.
Signed-off-by: Bruno Schaatsbergen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #36080
Our documentation suggests that module archives with
tar.bz2,tar.tbz2andtbz2can be fetched—howevertbz2was not supported.In go-getter there is a decompressor for tar archives compressed with bzip2 that can handle both
tar.bz2,tar.tbz2andtbz2files. See https://github.com/hashicorp/go-getter/blob/main/decompress_tbz2.go#L28-L48This PR adds support for decompressing tbz2 files, enabling the unpacking of tbz2 module archives, and improves the ordering of defined go-getter getter sets.