-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GEN-34: deer
: implement Content
IR
#2434
base: main
Are you sure you want to change the base?
Conversation
# Conflicts: # libs/deer/src/lib.rs
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2434 +/- ##
==========================================
+ Coverage 52.75% 56.41% +3.65%
==========================================
Files 331 341 +10
Lines 27555 26287 -1268
Branches 420 421 +1
==========================================
+ Hits 14538 14829 +291
+ Misses 13015 11453 -1562
- Partials 2 5 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
# Conflicts: # libs/deer/src/lib.rs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clippy found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
deer
: implement Content
IRdeer
: implement Content
IR
Once this move has taken place, this PR should be recreated there. |
🌟 What is the purpose of this PR?
This implements
Content
and relatedDeserializer
s, which is one of the last steps needed before we can start on the derive macro.🚫 Blocked by
deer
: implementDeserialize
for tuples #2418🚀 Has this modified a publishable library?
This PR: