H-1643: Add draft indicators to browser plugin jobs, add tooltips #4168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benwerner01
previously approved these changes
Mar 14, 2024
| @@ -114,47 +116,82 @@ const InferenceRequestContainer = ({ | |||
| {request.status === "pending" ? ( | |||
| <Stack alignItems="center" direction="row"> | |||
| {cancellationRequested ? ( | |||
| <Tooltip title="Cancellation pending..."> | |||
There was a problem hiding this comment.
Maybe we should rethink the positioning of the tooltips here, it's making it slightly harder to hover from the right icon to the left icon because of the placement:
Screen.Recording.2024-03-14.at.15.02.22.mov
…el/hash into cm/fix-browser-plugin-indicators
benwerner01
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌟 What is the purpose of this PR?
Breaks this commit out of #3953, which is stuck.
UX improvements to the browser plugin:
Pre-Merge Checklist 🚀
🚢 Has this modified a publishable library?
This PR:
📜 Does this require a change to the docs?
The changes in this PR:
🕸️ Does this require a change to the Turbo Graph?
The changes in this PR:
You might have to run the browser plugina via
yarn build && yarn startrather thanyarn devdue to some bundling issues which will be fixed by changes to@blockprotocol/coremade in blockprotocol/blockprotocol#1373, but that is blocked by converting a bunch of stuff in this repo to ESM.❓ How to test this?