-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
H-1978, H-1979, H-2013, H-2014: Update type icons, labels, dataTypes #5982
Draft
CiaranMn
wants to merge
8
commits into
main
Choose a base branch
from
cm/type-icon-plural-datatype-updates
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/apps > hash*
Affects HASH (a `hash-*` app)
area/infra
Relates to version control, CI, CD or IaC (area)
area/apps > hash-api
Affects the HASH API (app)
area/libs
Relates to first-party libraries/crates/packages (area)
type/eng > frontend
Owned by the @frontend team
type/eng > backend
Owned by the @backend team
area/tests
New or updated tests
area/tests > integration
New or updated integration tests
area/apps
labels
Dec 20, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5982 +/- ##
==========================================
- Coverage 21.72% 21.71% -0.02%
==========================================
Files 566 568 +2
Lines 19157 19170 +13
Branches 2755 2755
==========================================
Hits 4162 4162
- Misses 14943 14956 +13
Partials 52 52
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/apps > hash*
Affects HASH (a `hash-*` app)
area/apps > hash-api
Affects the HASH API (app)
area/apps
area/infra
Relates to version control, CI, CD or IaC (area)
area/libs
Relates to first-party libraries/crates/packages (area)
area/tests > integration
New or updated integration tests
area/tests
New or updated tests
type/eng > backend
Owned by the @backend team
type/eng > frontend
Owned by the @frontend team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌟 What is the purpose of this PR?
This PR contains a list of changes to:
pluralTitle
andinverse
titlesText
withURI
orDateTime
where appropriate)Image
->Image File
,Quick Note
–>Note
)It also contains the necessary TS type changes and where we specify a
dataTypeId
to make sure it is correct.The list of changes in the two files is intended for conversion into a migration script to overwrite types in the production db directly, to avoid the migration effort involved in updating all of these types to new versions (which would be significantly more complicated, given the dependency graph).
apps/hash-api/src/graph/ensure-system-graph-is-initialized/labels-icons-data-types.ts
apps/hash-api/src/graph/ensure-system-graph-is-initialized/provenance-defaults.ts
Deployment of this requires discussion as we need to coordinate the deployment of the Node API and frontend with the changes to types in the prod db, particurlarly due to:
dataTypeId
specified by the clients needs to match that expected by the API🚫 Blocked by
json-schema-to-typescript
which is generating data type enums differentlyPre-Merge Checklist 🚀
🚢 Has this modified a publishable library?
This PR:
📜 Does this require a change to the docs?
The changes in this PR:
🕸️ Does this require a change to the Turbo Graph?
The changes in this PR:
🐾 Next steps
Discuss coordination of changes.