Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

H-954: Migrate OSS edition of hCore #42

Merged
merged 48 commits into from
Oct 6, 2023
Merged

Conversation

judeallred
Copy link
Collaborator

No description provided.

@judeallred judeallred requested a review from a team as a code owner October 5, 2023 05:07
apps/sim-core/README.md Outdated Show resolved Hide resolved
apps/sim-core/README.md Outdated Show resolved Hide resolved
apps/sim-core/README.md Outdated Show resolved Hide resolved
apps/sim-core/README.md Outdated Show resolved Hide resolved
apps/sim-core/README.md Outdated Show resolved Hide resolved
apps/sim-core/README.md Outdated Show resolved Hide resolved
apps/sim-core/README.md Outdated Show resolved Hide resolved
apps/sim-core/README.md Outdated Show resolved Hide resolved
apps/sim-core/README.md Outdated Show resolved Hide resolved
apps/sim-core/README.md Outdated Show resolved Hide resolved
apps/sim-core/README.md Outdated Show resolved Hide resolved
apps/sim-core/README.md Outdated Show resolved Hide resolved
apps/sim-core/README.md Outdated Show resolved Hide resolved
apps/sim-core/README.md Outdated Show resolved Hide resolved
apps/sim-core/README.md Outdated Show resolved Hide resolved
Copy link
Member

@vilkinsons vilkinsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bunch of suggestions; many blocking (LICENSE, hCore project name, etc.)

Also one or two questions. I think we would benefit from reviewing all written READMEs in the directory and its sub-dirs as well as in-code comments. To discuss further internally.

@vilkinsons vilkinsons self-assigned this Oct 5, 2023
@vilkinsons
Copy link
Member

@judeallred FYI @CiaranMn will add some instructions for deploying this on Vercel. Maybe we can even configure the Vercel deploy button with the correct params (e.g. project path in-repo) to allow one-click deploying this?

@vilkinsons vilkinsons changed the title Migrate OSS edition of hCore H-954: Migrate OSS edition of hCore Oct 6, 2023
vilkinsons
vilkinsons previously approved these changes Oct 6, 2023
@vilkinsons vilkinsons merged commit b149727 into hashintel:main Oct 6, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants