GEN-126: Migrate hCore from Webpack 4 to Vite #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've got the build sorted now, now just need to sort out what's up with the web workers. |
|
I've pulled in some foundational upgrades that make this significantly easier to work on.
|
|
PR todos:
|
vilkinsons
changed the title
- remove sentry.io - .gitignore 'dist' - include 'embed.html' in the output
…ettier caching; sundry
- Turns out promise.resolve().then() doesn't actually accomplish the equivalent of a setImmediate. I was mislead by something online, oh well... setTimeout works. - The main simulation worker was breaking when you used the 'run' functionality because the thread would lock. A setTimeout (and previously, setImmediate) was needed to allow other events in the thread.
|
Promoted out of draft mode-- I've got core back to its functionality, but now without a huge amount of aged cruft. I haven't looked at the Vercel build yet. @CiaranMn if you could take a glance at that I'd be appreciative. |
This file was ignored and persisted across branches, thus causing fresh checkouts to break (as Vite no longer generates this) but existing checkouts to act "normal". I've removed the files and its special cases entirely, and added its contents into types.ts. This now repairs the build. Next up is pruning out the unused generated items and only keeping the relevant ones.
|
Vercel should be fixed. Will return to this and give myself a self-review, then it can merge. |
judeallred
commented
Dec 14, 2023
|
🎉 Awesome work, thanks Jude! |
vilkinsons
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was having trouble adding in modern libraries, such as oktokit, without hitting lots of babel and webpack-induced hurdles. By switching to vite, we stop using webpack and babel for 'core', instead making use of vite's defaults.
This review is still a draft-- While the site is online, there's some sort of communication problem with the web workers where they won't start/stop simulations (however single steps work fine). Additionally the 'build' step fails with an OOM error on my computer... this might be resolved by a bigger computer, or ideally by a smarter build config.