ErrorWrapper is no longer caught by catchSync (#283)

haskell-effectful · Dec 2, 2024 · f17d2a5 · f17d2a5
1 parent 4d428c6
commit f17d2a5
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/effectful-core/CHANGELOG.md b/effectful-core/CHANGELOG.md
@@ -1,6 +1,7 @@
 # effectful-core-2.6.0.0 (????-??-??)
 * **Breaking changes**:
   - Change the order of type parameters in `raise` for better usability.
+  - `Effectful.Error.Static.ErrorWrapper` is no longer caught by `catchSync`.
 
 # effectful-core-2.5.1.0 (2024-11-27)
 * Add `passthrough` to `Effectful.Dispatch.Dynamic` for passing operations to

diff --git a/effectful-core/src/Effectful/Error/Static.hs b/effectful-core/src/Effectful/Error/Static.hs
@@ -247,7 +247,10 @@ instance Show ErrorWrapper where
     . ("\n" ++)
     . (prettyCallStack cs ++)
 
-instance Exception ErrorWrapper
+instance Exception ErrorWrapper where
+  -- See discussion in https://github.com/haskell-effectful/effectful/pull/232.
+  toException = asyncExceptionToException
+  fromException = asyncExceptionFromException
 
 matchError :: ErrorId -> ErrorWrapper -> Maybe (CallStack, e)
 matchError eid (ErrorWrapper etag cs _ e)

diff --git a/effectful/CHANGELOG.md b/effectful/CHANGELOG.md
@@ -1,6 +1,7 @@
 # effectful-core-2.6.0.0 (????-??-??)
 * **Breaking changes**:
   - Change the order of type parameters in `raise` for better usability.
+  - `Effectful.Error.Static.ErrorWrapper` is no longer caught by `catchSync`.
 
 # effectful-2.5.1.0 (2024-11-27)
 * Add `passthrough` to `Effectful.Dispatch.Dynamic` for passing operations to