Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a great-big sad face if there are failed builds #125

Closed
wants to merge 2 commits into from
Closed

Conversation

glasnt
Copy link
Contributor

@glasnt glasnt commented Oct 6, 2016

Resolves #99

Preview:

Sadness

@glasnt
Copy link
Contributor Author

glasnt commented Oct 6, 2016

! @charleso @jystic maybe?

@charleso
Copy link
Contributor

charleso commented Oct 6, 2016

I defer to @russmaxdesign for all things style related. Seems fine at a glance.

Not sure about ":(" as the actual text, but don't necessarily have a better suggestion. Savage? :)

@charleso
Copy link
Contributor

charleso commented Oct 6, 2016

@glasnt As discussed can we possibly hold off on this until we get a second opinion from Mark who is quite fond of the plain red/green? :)

@charleso charleso removed their assignment Oct 11, 2016
@glasnt
Copy link
Contributor Author

glasnt commented Oct 28, 2016

Imma just gonna close this. Might pick it up on a Yak Day.

@glasnt glasnt closed this Oct 28, 2016
@glasnt glasnt deleted the topic/text branch June 19, 2017 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants