Temporarily drop EdDSA support until linking is sorted #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Packages which depend on tinfoil currently rely on linking with libsodium, which makes the executables they build nonportable. The right solution to this is linking to a static version of libsodium (#65) and/or split the package (#59), but until this can be fully implemented and pushed through to master, this is a temporary fix so we can build working client executables (ref https://github.com/ambiata/ambiata-cli/issues/59).
|
👍 seems fair |
olorin
added a commit
to haskell-mafia/zodiac
that referenced
this pull request
Nov 29, 2016
So we're not linking with libsodium unnecessarily. haskell-mafia/tinfoil#66
olorin
added a commit
to haskell-mafia/zodiac
that referenced
this pull request
Nov 29, 2016
So we're not linking with libsodium unnecessarily. haskell-mafia/tinfoil#66
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages which depend on tinfoil currently rely on linking with
libsodium, which makes the executables they build nonportable. The
right solution to this is linking to a static version of libsodium
(#65) and/or split the package (#59), but until this can be fully
implemented and pushed through to master, this is a temporary fix so
we can build working client executables (ref
https://github.com/ambiata/ambiata-cli/issues/59).
! @markhibberd