Add test for number of shared object dependencies #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thumphries
reviewed
Dec 28, 2016
| #------------------------------------- | ||
|
|
||
| nso="$(objdump -p $TSRP | grep -E '^\s+NEEDED' | wc -l)" | ||
| [ "$nso" = "8" ] || exit 10 |
There was a problem hiding this comment.
Will this be 8 forever?
There was a problem hiding this comment.
Maybe. It could increase in the future, but I figure incrementing an integer in a test when we add a new solib dependency is a small price to pay for not occasionally breaking in prod after working in CI. More detailed reasoning here, I did a similar thing for ambiata-cli (test is slightly pickier as we're actually distributing that executable).
There was a problem hiding this comment.
If it could change, it's worth adding a comment explaining the test and possibly enumerating the expected dependencies.
|
Good idea 👍 |
This has caused problems a few times and is a cheap test to add.
|
This looks to be more trouble than it's worth. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has caused problems a few times and is a cheap test to add.
Fixes #88.
! @thumphries