Merge pull request #563 from hats-finance/develop

Small fixes
hats-finance · Oct 2, 2023 · c46589b · c46589b
2 parents 4058721 + a492cbd
commit c46589b
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/...rc/pages/VaultEditor/VaultEditorFormPage/SetupSteps/ScopeDetailsForm/ScopeDetailsForm.tsx b/...rc/pages/VaultEditor/VaultEditorFormPage/SetupSteps/ScopeDetailsForm/ScopeDetailsForm.tsx
@@ -69,7 +69,7 @@ export const ScopeDetailsForm = () => {
   return (
     <StyledScopeDetailsForm>
       {/* Private audits alert */}
-      {isAdvancedMode && isPrivateAudit && (
+      {isPrivateAudit && (
         <Alert className="mt-2 mb-4" type="warning">
           {t("scopePrivateAuditsWarning")}
         </Alert>
@@ -126,7 +126,7 @@ export const ScopeDetailsForm = () => {
       )}
 
       {/* Repos and documentation */}
-      {isAdvancedMode && !isPrivateAudit && (
+      {!isPrivateAudit && (
         <>
           <p className="section-title mt-5">{t("VaultEditor.reposAndDocumentation")}</p>
           <ScopeReposInformation />

diff --git a/packages/web/src/pages/VaultEditor/VaultEditorFormPage/formSchema.ts b/packages/web/src/pages/VaultEditor/VaultEditorFormPage/formSchema.ts
@@ -74,10 +74,14 @@ export const getEditedDescriptionYupSchema = (intl: TFunction) =>
         Yup.object({
           url: Yup.string()
             .test(getTestGithubRepoUrl(intl))
-            .test("required", intl("required"), (val, ctx: any) => !!ctx.from[2].value["project-metadata"]?.isPrivateAudit),
+            .test("required", intl("required"), (val, ctx: any) =>
+              !!ctx.from[2].value["project-metadata"]?.isPrivateAudit ? true : !!val
+            ),
           commitHash: Yup.string()
             .test(getTestGitCommitHash(intl))
-            .test("required", intl("required"), (val, ctx: any) => !!ctx.from[2].value["project-metadata"]?.isPrivateAudit),
+            .test("required", intl("required"), (val, ctx: any) =>
+              !!ctx.from[2].value["project-metadata"]?.isPrivateAudit ? true : !!val
+            ),
           isMain: Yup.boolean(),
         })
       ),