Removed disallowedElementsMarkdown #555
Conversation
|
WalkthroughThe change primarily focuses on enhancing the markdown preview functionality in the Changes
Uplevel your code reviews with CodeRabbit ProCodeRabbit ProIf you like this project, please support us by purchasing the Pro version. The Pro version has advanced context, superior noise reduction and several proprietary improvements compared to the open source version. Moreover, CodeRabbit Pro is free for open source projects. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Files selected (1)
- packages/web/src/components/FormControls/FormMDEditor/FormMDEditor.tsx (2)
Review comments generated (2)
- Review: 2
- LGTM: 0
Tips
Chat with 
CodeRabbit Bot (@coderabbitai)
- Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
- Invite the bot into a review comment chain by tagging
@coderabbitaiin a reply.
Code suggestions
- The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
- You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.
Pausing incremental reviews
- Add
@coderabbitai: ignoreanywhere in the PR description to pause further reviews from the bot.
| @@ -1,5 +1,5 @@ | |||
| import MDEditor, { PreviewType } from "@uiw/react-md-editor"; | |||
| import { disallowedElementsMarkdown } from "constants/constants"; | |||
| import { allowedElementsMarkdown } from "constants/constants"; | |||
There was a problem hiding this comment.
The import statement has been changed from disallowedElementsMarkdown to allowedElementsMarkdown. Ensure that the allowedElementsMarkdown constant is correctly defined and contains all the necessary elements that should be allowed in the markdown editor. If it doesn't, you might face issues with rendering certain elements in the preview.
- import { disallowedElementsMarkdown } from "constants/constants";
+ import { allowedElementsMarkdown } from "constants/constants";| @@ -37,7 +37,7 @@ export const FormMDEditorComponent = ( | |||
| > | |||
| <MDEditor | |||
| value={value} | |||
| previewOptions={{ disallowedElements: disallowedElementsMarkdown }} | |||
| previewOptions={{ allowedElements: allowedElementsMarkdown }} | |||
There was a problem hiding this comment.
The previewOptions prop of the MDEditor component now uses allowedElementsMarkdown instead of disallowedElementsMarkdown. This change implies a shift from a blacklist approach to a whitelist approach for controlling what elements are rendered in the markdown preview. Make sure that this change aligns with your application's requirements and that all necessary elements are included in allowedElementsMarkdown.
- previewOptions={{ disallowedElements: disallowedElementsMarkdown }}
+ previewOptions={{ allowedElements: allowedElementsMarkdown }}
Deploying with
|
| Latest commit: |
d57e1a0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://42c03204.dapp-a9y.pages.dev |
| Branch Preview URL: | https://fix-removed-disallowedelemen.dapp-a9y.pages.dev |
Summary by CodeRabbit
FormMDEditorcomponent in the web package. The markdown preview options have been modified to only render specified elements, enhancing security and control over content display. This change improves the user experience by ensuring that only approved markdown elements are visible in the preview.