Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added private audits icon #564

Merged
merged 2 commits into from
Oct 3, 2023
Merged

Conversation

fonstack
Copy link
Member

@fonstack fonstack commented Oct 2, 2023

Summary by CodeRabbit

  • New Feature: Introduced a new PrivateAuditsIcon in the navigation links, enhancing the user interface and experience.
  • Chore: Removed unnecessary console.log statements across various files, improving code cleanliness and performance.

@fonstack fonstack requested a review from shayzluf October 2, 2023 16:57
@github-actions
Copy link

github-actions bot commented Oct 2, 2023

Image description CodeRabbit

Walkthrough

This update primarily focuses on two aspects: enhancing the user interface by introducing a new PrivateAuditsIcon in the navigation links, and improving code cleanliness by removing unnecessary console.log statements scattered across various files.

Changes

File(s) Summary
packages/web/src/components/Sidebar/NavLinks/NavLinks.tsx Introduced a new private audits icon (PrivateAuditsIcon) to the navigation links, replacing the previous AuditsIcon.
packages/web/src/hooks/subgraph/vaults/useVaults.tsx,
packages/web/src/pages/CommitteeTools/PayoutsTool/PayoutFormPage/PayoutFormPage.tsx,
packages/web/src/pages/Honeypots/VaultDetailsPage/savedSubmissionsService.ts,
packages/web/src/pages/Submissions/SubmissionFormPage/FormSteps/SubmissionDescriptions/SubmissionDescriptions.tsx
Removed various console.log statements for cleaner, more professional code. No changes were made to function signatures, global data structures, or variables.

🐇💻

In the land of code where the shadows lie,

An icon was changed, catching the eye.

Console logs removed, one by one,

Making the codebase clean and fun.

So here's to the devs, working night and day,

Your efforts are seen, hip hip hooray! 🎉


Uplevel your code reviews with CodeRabbit Pro

CodeRabbit Pro

If you like this project, please support us by purchasing the Pro version. The Pro version has advanced context, superior noise reduction and several proprietary improvements compared to the open source version. Moreover, CodeRabbit Pro is free for open source projects.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

Commits Files that changed from the base of the PR and between a492cbd and d294d31 commits.
Files selected (1)
  • packages/web/src/components/Sidebar/NavLinks/NavLinks.tsx (2)
Files ignored due to filter (1)
  • packages/web/src/assets/icons/custom/private-audits.svg
Files skipped from review due to trivial changes (1)
  • packages/web/src/components/Sidebar/NavLinks/NavLinks.tsx
Review comments generated (0)
  • Review: 0
  • LGTM: 0

Tips

Chat with Image description CodeRabbit Bot (@coderabbitai)

  • Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
  • Invite the bot into a review comment chain by tagging @coderabbitai in a reply.

Code suggestions

  • The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
  • You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Pausing incremental reviews

  • Add @coderabbitai: ignore anywhere in the PR description to pause further reviews from the bot.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 2, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: cf9fca1
Status: ✅  Deploy successful!
Preview URL: https://a3479fb0.dapp-a9y.pages.dev
Branch Preview URL: https://fix-fix-vault-editor-private.dapp-a9y.pages.dev

View logs

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

Commits Files that changed from the base of the PR and between d294d31 and cf9fca1 commits.
Files selected (4)
  • packages/web/src/hooks/subgraph/vaults/useVaults.tsx (1)
  • packages/web/src/pages/CommitteeTools/PayoutsTool/PayoutFormPage/PayoutFormPage.tsx (1)
  • packages/web/src/pages/Honeypots/VaultDetailsPage/savedSubmissionsService.ts (1)
  • packages/web/src/pages/Submissions/SubmissionFormPage/FormSteps/SubmissionDescriptions/SubmissionDescriptions.tsx (1)
Files skipped from review due to trivial changes (4)
  • packages/web/src/hooks/subgraph/vaults/useVaults.tsx
  • packages/web/src/pages/CommitteeTools/PayoutsTool/PayoutFormPage/PayoutFormPage.tsx
  • packages/web/src/pages/Honeypots/VaultDetailsPage/savedSubmissionsService.ts
  • packages/web/src/pages/Submissions/SubmissionFormPage/FormSteps/SubmissionDescriptions/SubmissionDescriptions.tsx
Review comments generated (0)
  • Review: 0
  • LGTM: 0

Tips

Chat with Image description CodeRabbit Bot (@coderabbitai)

  • Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
  • Invite the bot into a review comment chain by tagging @coderabbitai in a reply.

Code suggestions

  • The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
  • You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Pausing incremental reviews

  • Add @coderabbitai: ignore anywhere in the PR description to pause further reviews from the bot.

@shayzluf shayzluf merged commit f871205 into develop Oct 3, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants